Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix renaming from cluster_id to cloud_account #455

Merged
merged 3 commits into from
Jan 22, 2025
Merged

Fix renaming from cluster_id to cloud_account #455

merged 3 commits into from
Jan 22, 2025

Conversation

tchaton
Copy link
Collaborator

@tchaton tchaton commented Jan 22, 2025

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes # (issue).

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78%. Comparing base (08bf77d) to head (5d73cc0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #455   +/-   ##
===================================
- Coverage    79%    78%   -0%     
===================================
  Files        35     35           
  Lines      5123   5123           
===================================
- Hits       4027   4019    -8     
- Misses     1096   1104    +8     

@tchaton tchaton merged commit b86ab3f into main Jan 22, 2025
29 checks passed
@tchaton tchaton deleted the fix_renaming branch January 22, 2025 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant