Ingress Endpoint Implementation #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dixon Whitmire <[email protected]>
Signed-off-by: Dixon Whitmire <[email protected]>
Closed
Signed-off-by: Dixon Whitmire <[email protected]>
ccorley
reviewed
Nov 23, 2021
| with open(file_path, "r") as f: | ||
| return json.loads(f.read()) | ||
| def fhir_resource(fhir_fixture) -> Dict: | ||
| return json.loads(fhir_fixture) | ||
|
|
There was a problem hiding this comment.
Nice - a fixture based on a fixture...
ccorley
reviewed
Nov 23, 2021
ccorley
requested changes
Nov 23, 2021
Signed-off-by: Dixon Whitmire <[email protected]>
Closed
ccorley
approved these changes
Nov 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds /ingress and /ingress/upload endpoints to connect. The "ingress" endpoints are used to handle all supported health protocols/formats including ASC X12, DICOM, FHIR, and HL7 (C-CDA is slated for a future release). The "ingress" provide a single integration point which removes the need for separate endpoints for each format.
Changes include:
I will create a new issue to support a configurable maximum request size for /ingress [POST]. The idea being that if a payload exceeds the size, clients would use /ingress/upload [POST] to upload the data message.
We will continue to store EDI message payloads within Kafka until #311 is implemented.
resolves #278 , #281 , #299