-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LF18.1 #2829
Merged
Merged
LF18.1 #2829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add support for the `rows` attribute * change default height
) * refactor(luTooltip): first pass of luTooltip refactor * chore(tooltips): better ellipsis logic and auto text feed * chore(tooltips): tests fix and better aria-describedby management * chore: wrapper with mask (#2749) * chore(tooltip): code structure fixes * chore(tooltip): avoid ResizeObserver leaks * chore(tooltip): use renderer as much as possible for DOM manipulation * chore(tooltip): imports cleanup * tooltip component + wip animations * chore(tooltip): connect position logic for new CSS animations * chore(tooltip): we don't need LuClass anymore on panel --------- Co-authored-by: Vincent Valentin <[email protected]> Co-authored-by: Vincent Valentin <[email protected]>
* Focus visible for tooltip informations in labels * fix labels
* fix(front) : conflicts * fix(front) : replace arobase with at * fix(front) : css vars standardization * feat(front) : new table stories for sticked + fixed overhaul * Small adjustments for table sticky (#2805) * fix documentation + fix QA --------- Co-authored-by: Vincent Valentin <[email protected]> Co-authored-by: Vincent Valentin <[email protected]>
* Remove border for prefix and suffix and add mod-alignRight * alignRight Angular * comment + valueAlignRight * fix lint ? * fix paddings & add QA stories --------- Co-authored-by: Jérémie Biron <[email protected]>
* Empty state titles * union type
* refacto loading * css vars fallback
This has to be made using *luMultiDisplayer for now but ideally, the displayer should fill itself inside the parent multi-select, not sure we can do it tho.
* feat: Add comment component * fix: spacings variables * Adjustements for comment component (#2811) * Adjustements for comment component * ngsp * reduce breakpoint size --------- Co-authored-by: Vincent Valentin <[email protected]> Co-authored-by: Jérémie Biron <[email protected]>
* fix boxshadow style * use css var
* refactor(empty-states): make title and description optional * add description class & apply margin on actions * add role presentation when no title * fix html --------- Co-authored-by: Jérémie Biron <[email protected]>
* responsive + container + css vars + story * remove mixin * remove class for mod-narrow
* [2078] Add multiple users on LuUserDisplayPipe [2078] Add multiple user display example on story [2078] Improve code readability [2078] Throw error when user is not defined [2078] Improve getFirstCharacter function [2078] Fix * [2078] Add Intl formatter on UserDisplayPipe
* Tag NG component * fixees * Update packages/ng/tag/tag.component.html Co-authored-by: Corentin <[email protected]> * href > routerlink * chore(lint): fix tag html indent --------- Co-authored-by: Corentin <[email protected]> Co-authored-by: Flavien Normand <[email protected]>
vvalentin-lucca
approved these changes
Jun 18, 2024
GuillaumeNury
approved these changes
Jun 18, 2024
Supamiu
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
📖 Documentation changes
Requires a Prisme update
🔖🐛 FIX
Bug / Visual fix (PR should target Master branch)
🔖✨ Feature
New feature (even a very small one)
🔨 Technical
Doesn't affect the output (refactor, dependencies update, cleaning, etc.)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Actions required to update
Removed elements
A bunch of deprecated components & classes has been removed (see the list) and need to be replaced if still used.
If you face update troubles due to this deletion, please join us on dedicated slack channel (#lucca-front-public), we keep deleted CSS on hand.
Timepicker import
We provided new Time/Duration picker. Old CSS import:
... must be replaced by:
Table fixed & sticked import
We provided an updated version of table fixed & sticked that fix shadow bugs and save dist weight.
If you'd rather to update it later, these imports:
... must be replaced by:
🚧 Add new fixed / sticked table documentation
🎉 Features
luPopover2
directive for better DX, better accessibility and maintainability #2852canClose
option inLuDialogService
fixed(lu-dialog): handled canClose option in LuDialogService #2733delete
option to cover invalid hover style (trash icon) feat(button): adddelete
input that addsmod-delete
to button classes #2773luUserInput
format feat(user): allow string union type for luUserInput format #2789LuUserDisplayPipe
[2078] Add multiple users param on LuUserDisplayPipe #2088rows
attribute Add support for therows
attribute #2788🎨 Visual changes
🚑 Fixes
📖 Documentation
🔨 Technical
type="button"
is now apply by default onluButton
when type is not defined feat(button): apply default type set tobutton
when not present on the button #2775rosetta
mixin to map new / old CSS vars Rosetta mixin #2840💀 Deprecated
All information related to deprecated elements