feat(schematics): lu-select migration schematic #3292
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New
lu-select
schematic to migrate as manylu-select
as we can into new simple/multiple selects.Opening this as a draft because I'm on holidays for 3 weeks this evening and I want to be able to keep track of everything + allow anyone to contribute if they want to.
Here is the goal todo list, with some example cases:
lu-select
with simple option-picker intolu-simple-select
(example: https://github.com/LuccaSA/Lucca.AppStore/blob/b9ea2d9b4154800760ad616a772348fc8f4f8a0c/front/src/app/shared/components/culture-select/translation-orchestrator.component.html#L6-L16 but this one is inside the tests already).*luDisplayer
into its modern version (ng-container *luDisplayer
)lu-option
rendering into its modern version (ng-container *luOptionDisplayer
)lu-establishment-select
,lu-user-select
orlu-qualification-select
into corresponding select with api directivelu-api-select
into corresponding select withapiVX
directive depending on thestandard
usedlu-option-picker-advanced
and simple feeder/option combo: https://github.com/LuccaSA/Timmi.Timesheet/blob/1f95fac02a010cce18933969217d6b5972840454/front/projects/pwa/src/app/pages/settings/pages/rules/components/cumulation-rule/cumulation-rule.component.html#L10-L32input-clearer
intoclearer
on new selectCases we need to filter and add a comment to explain why:
lu-department-select
is a tree picker, we don't have a modern version of this yetlu-option
rows instead of having them in an array inside TS, migrating this would mean parsing and then building the array in TS which might be a bit too complex for now.lu-option-select-all
cannot be migrated as-is, since the new select-all behavior changes the underlying data model.tree-option-picker
cannot be migrated, we don't have a modern version of it.lu-option
with[value]
using a nested key in the option value from arraylu-establishment-select
,lu-user-select
orlu-qualification-select
with their service overrided inside@Component
'sproviders
.lu-option-picker
that's not from LF as direct child of the picker (even just adiv
, because it means custom panel content and we can't do that): https://github.com/LuccaSA/Cleemy.Banking/blob/0e74c48401564e4d72fdfa8e5e4d02da59abc22e/front/src/components/transactions/components/transactions-filters/transactions-filters.component.html#L30-L42