Making baseline not reliant on a line numbers #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @Humni,
As discussed in this issue, I am trying to make your package not reliant on line numbers.
Instead of hashing filePath, message.line, message.column, and message.ruleId, I hash filePath, message.ruleId, and context for comparison of errors instead.
Context is composed of the file lines (one before the error, the error line, and one after it), trimmed from both sides.
Also, the baseline is sorted by file>ruleId>line in order to make it stable between rebuilds.
Let me know if any changes are needed!