Add condition to shader module assertion post pipeline creation #1943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the specs VkPipelineShaderStageCreateInfo can specify a null shader module. If module is VK_NULL_HANDLE, the shader code is defined by the chained VkShaderModuleCreateInfo if present. Change-Id: I8383a372c383bd9e2f0e03dc0ab28b6fc195824d
|
CI gfxreconstruct build queued with queue ID 339360. |
|
CI gfxreconstruct build # 5702 running. |
|
CI gfxreconstruct build # 5702 passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the specs VkPipelineShaderStageCreateInfo can specify a null shader module. If module is VK_NULL_HANDLE, the shader code is defined by the chained VkShaderModuleCreateInfo if present.
Currently in this scenario gfxreconstruct will trigger assert on missing shader_wrapper.
With this change the assert will be skipped and the shader wrapper will not be added to bound shaders list.