Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade skip connect #107

Closed
wants to merge 11 commits into from
Closed

upgrade skip connect #107

wants to merge 11 commits into from

Conversation

mantrachain-support
Copy link
Contributor

@mantrachain-support mantrachain-support commented Sep 18, 2024

Summary by CodeRabbit

  • New Features

    • Transitioned to updated versions of market map and oracle modules for improved functionality.
  • Bug Fixes

    • Updated dependencies to more stable versions, enhancing performance and fixing existing issues.
  • Chores

    • Renamed and modified test workflow to focus on connectivity integration tests.
    • Updated import paths and repository references in integration tests for better organization and clarity.

Copy link

coderabbitai bot commented Sep 18, 2024

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The pull request introduces significant updates across multiple files, including changes to import paths and module references in app/app_config.go, which transition to newer module versions. The go.mod file has been updated to reflect stable versions of dependencies, including the replacement of github.com/skip-mev/slinky with github.com/skip-mev/connect. Additionally, workflow configurations in .github/workflows/connect-test.yml have been refined to execute specific integration tests. These changes collectively enhance module management and streamline testing processes.

Changes

Files Change Summary
app/app_config.go Renamed imports from marketmapmodulev1 and oraclemodulev1 to marketmapmodule and oraclemodule.
go.mod Updated github.com/skip-mev/connect/v2 from a pseudo-version to v2.0.1; updated indirect dependencies for github.com/pelletier/go-toml/v2 to v2.2.3 and github.com/prometheus/client_golang to v1.20.4.
.github/workflows/connect-test.yml Renamed workflow from "Test" to "Skip Connect Integration Test"; changed command from echo "Replace me" to make test-connect.
tests/connect/connect_integration_test.go Updated import paths to point to github.com/skip-mev/connect/v2 and changed Docker image repository for oracleImage.
tests/connect/go.mod Replaced github.com/skip-mev/slinky with github.com/skip-mev/connect and updated several dependencies.

Possibly related PRs

  • feat: skip-mev connectv2 #6: The changes in app/app_config.go regarding the integration of new modules for market mapping and oracle functionalities are directly related to the updates made in the same file in this PR, which also involves modifications to module imports and configurations.
  • deps: bump deps #28: The updates to the go.mod file in the main PR, which include changes to dependencies related to the github.com/skip-mev/connect module, are relevant to the dependency updates in this PR, as both involve maintaining and upgrading dependencies for compatibility and functionality.

Poem

🐇 In the garden of code, changes bloom bright,
With modules renewed, everything feels right.
Dependencies dance, in versions they play,
A hop and a skip, into a new day!
So let’s cheer for the updates, both shiny and new,
For a smoother tomorrow, we’ll code and we’ll brew! 🌼


Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai generate interesting stats about this repository and render them as a table.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@mantrachain-support
Copy link
Contributor Author

This will allow merging #32

@mantrachain-support mantrachain-support marked this pull request as draft September 18, 2024 17:04
@mantrachain-support
Copy link
Contributor Author

This pr should be handled only after the docker images for sidecar v2 (?) are released, and we should merge #97 instead for now.

@freeelancer freeelancer deleted the mantrachain/connectv2 branch December 10, 2024 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant