Adding term.forceUpdate() function. #344
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MCJack123
requested changes
Mar 2, 2024
There was a problem hiding this comment.
The concept is good, but I'd like to avoid making new functions if possible. Could you move the functionality into setFrozen(false) instead?
Also, I'm concerned about the lack of buffering - it's possible for the application to request an update, but then change the screen before it gets rendered, which could still result in a partial paint. To fix this, there'd need to be some sort of buffer holding the requested render state. Personally I'd like a Lua solution, such as a framebuffer API, but it may be more convenient to put it in C instead - I'll leave this to you to decide on.
| @@ -152,6 +152,7 @@ class Terminal { | |||
|
|
|||
| // The following fields are available in API version 10.1 and later. | |||
| bool frozen = false; // Whether the terminal should stop rendering | |||
| bool forcedUpdate = false; // Ignores `frozen` to render the terminal once | |||
There was a problem hiding this comment.
This must be placed at the end of the class - the current position would break ABI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is currently no way to syncronise when to freeze and unfreeze the terminal/monitor once a Lua program is finished drawing, so I've made this function to force it (just ignore that it's frozen) to render the contents of the terminal once. (A better name can be chosen if needed.)
The ROM should also now expect this function or else it will give an error "Redirect object is missing method forceUpdate."