-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update deploy for OIDC credentials #136
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #136 +/- ##
=======================================
Coverage 87.55% 87.55%
=======================================
Files 5 5
Lines 747 747
Branches 127 127
=======================================
Hits 654 654
Misses 56 56
Partials 37 37 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this now run in a deploy environment?
Do we have to configure this environment in the repo settings? Presumably, this environment has to be listed in the Trusted Publisher settings, right?
|
We do need to delete out the token secrets in the |
I just removed the two tokens from "deploy". |
Have to dash... will continue on MDAnalysisData later tonight. |
It's been a long day, I hope that I've changed all the references from mda-xdrlib to GridDataFormats properly!