Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deploy for OIDC credentials #136

Merged
merged 3 commits into from
Oct 29, 2023
Merged

Update deploy for OIDC credentials #136

merged 3 commits into from
Oct 29, 2023

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Oct 27, 2023

It's been a long day, I hope that I've changed all the references from mda-xdrlib to GridDataFormats properly!

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (354ec73) 87.55% compared to head (a45ad81) 87.55%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #136   +/-   ##
=======================================
  Coverage   87.55%   87.55%           
=======================================
  Files           5        5           
  Lines         747      747           
  Branches      127      127           
=======================================
  Hits          654      654           
  Misses         56       56           
  Partials       37       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@orbeckst orbeckst self-assigned this Oct 29, 2023
Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this now run in a deploy environment?

Do we have to configure this environment in the repo settings? Presumably, this environment has to be listed in the Trusted Publisher settings, right?

@IAlibay
Copy link
Member Author

IAlibay commented Oct 29, 2023

Does this now run in a deploy environment?

Do we have to configure this environment in the repo settings? Presumably, this environment has to be listed in the Trusted Publisher settings, right?

deploy already exists and I believe I set up the trusted settings with the env name.

@IAlibay
Copy link
Member Author

IAlibay commented Oct 29, 2023

We do need to delete out the token secrets in the deploy environment though.

@orbeckst orbeckst merged commit e768b0f into master Oct 29, 2023
9 checks passed
@orbeckst orbeckst deleted the oidc-deployment branch October 29, 2023 20:49
@orbeckst
Copy link
Member

I just removed the two tokens from "deploy".

@orbeckst
Copy link
Member

Have to dash... will continue on MDAnalysisData later tonight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants