Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPADL] Do not insert synthetic dribbles before headed shots #613

Closed
wants to merge 3 commits into from

Conversation

ksbharaj
Copy link
Contributor

Fix to remove occurrences where a dribble is added immediately before a headed shot

@codecov-commenter
Copy link

codecov-commenter commented Oct 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (796593c) 82.79% compared to head (aa7f3d3) 82.83%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #613      +/-   ##
==========================================
+ Coverage   82.79%   82.83%   +0.03%     
==========================================
  Files          47       47              
  Lines        3395     3402       +7     
  Branches      565      565              
==========================================
+ Hits         2811     2818       +7     
  Misses        491      491              
  Partials       93       93              
Files Coverage Δ
socceraction/spadl/base.py 96.61% <100.00%> (+0.45%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@probberechts probberechts changed the title Removal of dribbles before a headed shot [SPADL] Do not insert synthetic dribbles before headed shots Dec 30, 2023
@probberechts probberechts added the bug Something isn't working label Dec 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants