Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for passing integer(8) values to mpas_log_write. #1261

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

jim-p-w
Copy link
Contributor

@jim-p-w jim-p-w commented Jan 7, 2025

This PR allows callers of mpas_log_write to provide values of type integer(8).

The placeholder specification is $w for integer(8) values, as opposed to $i for integer values.

I ran a test where I interspersed integer and integer(8) values, e.g.

integer, dimension(:), allocatable :: intarray
integer(8), dimension(:), allocatable :: int8array
...
call mpas_log_write('SMIOLf_get_var error $i i81:$w int1:$i i82:$w int2:$i i83:$w', intArgs=[local_ierr, intarray(1), intarray(2)], int8Args=int8array, messageType=MPAS_LOG_ERR)

src/framework/mpas_log.F Outdated Show resolved Hide resolved
src/framework/mpas_log.F Outdated Show resolved Hide resolved
@mgduda
Copy link
Contributor

mgduda commented Jan 7, 2025

@jim-p-w Can you add more detail to the commit message?

@jim-p-w
Copy link
Contributor Author

jim-p-w commented Jan 7, 2025

@jim-p-w Can you add more detail to the commit message?

@mgduda How about:
Allow passing values of type integer(8)/integer(kind=I8KIND) to mpas_log_write.
The string $j is used to identify integer(kind=I8KIND) values.

I'm open to suggestions about what the commit message says.

…log_write.

The string $j is used to identify integer(kind=I8KIND) values.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants