Switch setup configurations to pyproject.toml
#226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xylar
reviewed
Jan 7, 2025
xylar
reviewed
Jan 8, 2025
There was a problem hiding this comment.
Yep, other than the one switch from exclude to include that we discussed yesterday, I think this looks great and is ready to merge. I'll merge once that change is in and once CI has passed.
I'm going to go ahead and commit the change. I hope that's okay with you.
xylar
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I've switched the setup configurations from the
setup.pyapproach to the more updatedpyproject.tomlapproach that we're adopting in other repos.