Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atomic Zora Relativity #496

Merged
merged 53 commits into from
Nov 7, 2024
Merged

Conversation

moritzgubler
Copy link
Contributor

This branch implements the atomic ZORA relativistic approximation where the Zora potential is precomputed for each element and a superposition of atomic potentials is the zora potential.

Copy link
Contributor

@ilfreddy ilfreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing AZORA! Could you also include tests for it? It does not seem to me there are any at the moment.

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.16%. Comparing base (f258b45) to head (764eb22).
Report is 102 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #496      +/-   ##
==========================================
+ Coverage   68.73%   69.16%   +0.43%     
==========================================
  Files         194      202       +8     
  Lines       15290    15646     +356     
==========================================
+ Hits        10510    10822     +312     
- Misses       4780     4824      +44     
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@moritzgubler
Copy link
Contributor Author

@ilfreddy I added testing

@ilfreddy ilfreddy merged commit 72cb685 into MRChemSoft:master Nov 7, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants