-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Atomic Zora Relativity #496
Atomic Zora Relativity #496
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for implementing AZORA! Could you also include tests for it? It does not seem to me there are any at the moment.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #496 +/- ##
==========================================
+ Coverage 68.73% 69.16% +0.43%
==========================================
Files 194 202 +8
Lines 15290 15646 +356
==========================================
+ Hits 10510 10822 +312
- Misses 4780 4824 +44
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@ilfreddy I added testing |
This branch implements the atomic ZORA relativistic approximation where the Zora potential is precomputed for each element and a superposition of atomic potentials is the zora potential.