dropping references to vm lifecycle events #1736
Conversation
|
This pull request has been automatically marked as stale because it has not been updated for at least 3 months. If these changes are still valid, please remove the Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation. |
| @@ -11,7 +11,6 @@ Events are triggers that cause a condition to be tested. Control provides severa | |||
| | Orchestration Lifecycle | Events related to orchestration lifecycle, such as retirement. | | |||
| | Physical Server Operation | Events related to the connection state of a physical server. | | |||
| | VM Configuration | Events associated with a change in configuration of a virtual machine. These include, but are not limited to, clone, create, template create, and settings change. | | |||
| | VM Lifecycle | Events such as virtual machine discovery, provisioning, and virtual machine retirement. | | |||
There was a problem hiding this comment.
This should not be removed. We do still have the lifecycle events, we just don't have it as a dedicated model.
There was a problem hiding this comment.
Same here, this should not be removed. (Though it being named cfme_lifecycle is wrong :) )
|
update:
I'm confused. Is any of this still good or should I just drop this PR? |
kbrock
force-pushed
the
drop_lifecycle_events
branch
from
685cd25 to
8df78ba
Compare
|
Checked commit kbrock@8df78ba with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint |
part of ManageIQ/manageiq#21204
I did a quick search.
Just wanted to see if we could move this conversation forward