Refactor readers i #232
Merged
Refactor readers i #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jalew188
reviewed
Nov 13, 2024
|
LGTM! |
GeorgWa
approved these changes
Nov 13, 2024
There was a problem hiding this comment.
Looks good!
Two comments from my side:
- although the readers have the psm_df the same data frame is called precursor_df in the rest of the codebase when present in spectral libraries etc. we could unify this at some point.
- some of the columns used here are temporary or redundant as they will be removed later. That’s not great software engineering wise but maybe we can mark them with an underscore.
lucas-diedrich
approved these changes
Nov 14, 2024
|
@GeorgWa thanks for the heads up regarding precursor_df & the unused columns, noted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some refactorings of the PSM readers
use
_psm_dfiternally instead ofpsm_df(first commit)simplify column_mapping initialization (second commit)
Introduce string constants to access the data frames in the reader classes.
Benefits: the relation between the different locations where columns are accessed becomes transparent.