Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linting iii #235

Merged
merged 17 commits into from
Jan 9, 2025
Merged

Linting iii #235

merged 17 commits into from
Jan 9, 2025

Conversation

mschwoer
Copy link
Contributor

@mschwoer mschwoer commented Nov 15, 2024 •
edited
Loading

manual fixes for a first bunch of linting rules ..
see individual commits

edit: made all start imports in notebooks explicit as tests started to fail due to removal of os from some readers

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

GeorgWa
GeorgWa approved these changes Nov 20, 2024
View reviewed changes
Copy link
Collaborator

@GeorgWa GeorgWa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I think the Path() / Path() syntax is quite ugly and missuses python magic methods :D but if the community thinks this is the way to go I'm happy to do so.
I'm also not a big fan of ther new read only .to_numpy() buit I guess I have to live with this.

alphabase/psm_reader/alphapept_reader.py Show resolved Hide resolved
alphabase/psm_reader/maxquant_reader.py Show resolved Hide resolved
alphabase/psm_reader/sage_reader.py Show resolved Hide resolved
alphabase/spectral_library/reader.py Show resolved Hide resolved
Base automatically changed from linting_II to development November 22, 2024 09:51
@mschwoer mschwoer merged commit 4e2b51f into development Jan 9, 2025
2 checks passed
@mschwoer mschwoer deleted the linting_III branch January 9, 2025 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeorgWa GeorgWa GeorgWa approved these changes

@jalew188 jalew188 Awaiting requested review from jalew188

@lucas-diedrich lucas-diedrich Awaiting requested review from lucas-diedrich

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mschwoer @GeorgWa