remove_unused_fragments bug fix #270
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jalew188
reviewed
Jan 9, 2025
| from alphabase.peptide.fragment import remove_unused_fragments | ||
|
|
||
|
|
||
| def example_remove_unused_fragments(): |
There was a problem hiding this comment.
Use pytest, see other py files in the tests folder
jalew188
reviewed
Jan 9, 2025
| frag_idx = precursor_df[[frag_start_col, frag_stop_col]].values | ||
|
|
||
| new_frag_idx, fragment_pointer = compress_fragment_indices(frag_idx) | ||
|
|
||
| precursor_df[[frag_start_col, frag_stop_col]] = new_frag_idx | ||
| precursor_df = precursor_df.sort_index() |
There was a problem hiding this comment.
sort_index() is to keep the original order of returned precursr_df as the input precursor_df. May be it is fine to keep this here.
There was a problem hiding this comment.
You're right; the original order should be preserved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #269