Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor config #411

Merged
merged 18 commits into from
Jan 9, 2025
Merged

Refactor config #411

merged 18 commits into from
Jan 9, 2025

Conversation

mschwoer
Copy link
Collaborator

@mschwoer mschwoer commented Dec 19, 2024

Refactor the config class:

  • separate merging and printing (up to the tracking_config variable)
  • add more fine grained unit tests

@mschwoer mschwoer added the test:e2e End to end tests will be run on PRs that carry this label. label Dec 19, 2024
@mschwoer mschwoer marked this pull request as ready for review December 20, 2024 14:21
@mschwoer mschwoer force-pushed the add_unit_test_for_config branch from d91f9be to 42b4798 Compare December 20, 2024 14:44
Copy link
Collaborator

@GeorgWa GeorgWa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much cleaner implementation! LGTM

alphadia/constants/default.yaml Outdated Show resolved Hide resolved
alphadia/workflow/config.py Show resolved Hide resolved
alphadia/workflow/config.py Outdated Show resolved Hide resolved
alphadia/workflow/config.py Outdated Show resolved Hide resolved
alphadia/workflow/config.py Show resolved Hide resolved
…efactor_config

# Conflicts:
#	.github/workflows/_run_tests.yml
#	misc/pip_install.sh
#	tests/unit_tests/test_config.py
@mschwoer mschwoer requested a review from mo-sameh January 8, 2025 16:46
Base automatically changed from add_unit_test_for_config to development January 9, 2025 09:35
@mschwoer mschwoer merged commit 23bd169 into development Jan 9, 2025
5 checks passed
@mschwoer mschwoer deleted the refactor_config branch January 9, 2025 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change test:e2e End to end tests will be run on PRs that carry this label.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants