Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor config2 #415

Merged
merged 10 commits into from
Jan 9, 2025
Merged

Refactor config2 #415

merged 10 commits into from
Jan 9, 2025

Conversation

mschwoer
Copy link
Collaborator

  • make the config an actual dict, simplify the way it is initialized
  • remove ability to set config_base_path

@mschwoer mschwoer requested a review from GeorgWa December 20, 2024 15:38
@mschwoer mschwoer force-pushed the refactor_config2 branch 2 times, most recently from 1e853ea to 0d62ae9 Compare December 20, 2024 17:09
@mschwoer mschwoer added test:e2e End to end tests will be run on PRs that carry this label. and removed test:e2e End to end tests will be run on PRs that carry this label. labels Dec 20, 2024
@mschwoer mschwoer added test:e2e End to end tests will be run on PRs that carry this label. and removed test:e2e End to end tests will be run on PRs that carry this label. labels Dec 20, 2024
@mschwoer mschwoer added the test:e2e End to end tests will be run on PRs that carry this label. label Dec 23, 2024
Copy link
Collaborator

@GeorgWa GeorgWa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from change_config_handling to development January 9, 2025 11:14
@mschwoer mschwoer requested a review from mo-sameh January 9, 2025 11:15
@mschwoer mschwoer merged commit 15ee261 into development Jan 9, 2025
5 checks passed
@mschwoer mschwoer deleted the refactor_config2 branch January 9, 2025 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test:e2e End to end tests will be run on PRs that carry this label.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants