-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor config2 #415
Merged
Merged
Refactor config2 #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mschwoer
commented
Dec 20, 2024
- make the config an actual dict, simplify the way it is initialized
- remove ability to set config_base_path
mschwoer
force-pushed
the
refactor_config2
branch
2 times, most recently
from
December 20, 2024 17:09
1e853ea
to
0d62ae9
Compare
mschwoer
added
test:e2e
End to end tests will be run on PRs that carry this label.
and removed
test:e2e
End to end tests will be run on PRs that carry this label.
labels
Dec 20, 2024
mschwoer
force-pushed
the
refactor_config2
branch
from
December 20, 2024 21:09
c66eec4
to
889979c
Compare
mschwoer
added
test:e2e
End to end tests will be run on PRs that carry this label.
and removed
test:e2e
End to end tests will be run on PRs that carry this label.
labels
Dec 20, 2024
mschwoer
force-pushed
the
refactor_config2
branch
from
December 23, 2024 14:21
d33dca7
to
1aae6c2
Compare
mschwoer
added
the
test:e2e
End to end tests will be run on PRs that carry this label.
label
Dec 23, 2024
GeorgWa
approved these changes
Dec 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.