Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix fdr bug #418

Merged
merged 5 commits into from
Jan 14, 2025
Merged

fix fdr bug #418

merged 5 commits into from
Jan 14, 2025

Conversation

mschwoer
Copy link
Collaborator

@mschwoer mschwoer commented Dec 20, 2024

"fix" the FDR "bug" by reducing number of threads for FDR classification task
apparently it does not scale well:

large task (linux machine w/ 32 physical cores, 64 is hyperthreading):
image

small task:
image

install mono in CI
Copy link
Collaborator

@GeorgWa GeorgWa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

alphadia/fdr.py Show resolved Hide resolved
Copy link
Collaborator

@GeorgWa GeorgWa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let’s merge this

@mschwoer mschwoer merged commit 79cd81d into development Jan 14, 2025
7 checks passed
@mschwoer mschwoer deleted the fix_fdr_bug branch January 14, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants