Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ShellExt: Move file extensions list from XML to DLL + implement .lnk shortcut handling #1006

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

cjee21
Copy link
Collaborator

@cjee21 cjee21 commented Jan 3, 2025

See #994 (comment) and #998 (comment)

Known limitations:
If shortcut target is a long path, it does not work due to path length limitations of IShellLink::GetPath.

@cjee21
Copy link
Collaborator Author

cjee21 commented Jan 3, 2025

I give up on implementing shortcut handling. Seems too much work.

After this PR, MediaInfo will likely not appear in classic context menu for shortcuts since we are now doing extension checking ourselves. Before, Windows will parse shortcuts and check if destination extension is in our manifest when using the classic menu.
Turns out it still works as before so no regression for this case.

@cjee21
Copy link
Collaborator Author

cjee21 commented Jan 3, 2025

Updated file extensions lists generator: MediaInfo_fileextensions.xlsx

@cjee21
Copy link
Collaborator Author

cjee21 commented Jan 3, 2025

MediaInfo entry is showing on archives now.....

@cjee21
Copy link
Collaborator Author

cjee21 commented Jan 3, 2025

MediaInfo entry is showing on archives now.....

Fixed in force push.

Also noticed MediaInfo is now no longer the first entry in classic context menu. Hope it won't undo the effects of the previous Verb Id renaming workarounds.

@cjee21
Copy link
Collaborator Author

cjee21 commented Jan 4, 2025

I give up on implementing shortcut handling. Seems too much work.

Another attempt. Not easy but managed to get it working. :D

Now need to rebase either this or #1002 else there will be no shortcut handling for multi-instance.

Also drag and drop in MediaInfo does not handle shortcuts as well as opening a folder containing shortcuts.

For .url files, I think better to handle it in GUI itself along with drag&drop.

@cjee21
Copy link
Collaborator Author

cjee21 commented Jan 4, 2025

@JeromeMartinez Ubuntu-latest runner on GitHub has updated to 24.04, 'libwxgtk3.0-gtk3-dev' no longer exists causing CI failure.

Update: Fixed in #1007

@cjee21 cjee21 changed the title ShellExt: Move file extensions list from XML to DLL ShellExt: Move file extensions list from XML to DLL + implement .lnk shortcut handling Jan 4, 2025
@cjee21 cjee21 force-pushed the shell-exts branch 6 times, most recently from dd9b88e to a0beaac Compare January 7, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant