Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows GUI: Code clean-up, organization and fixes #902

Merged
merged 5 commits into from
Jul 2, 2024

Conversation

cjee21
Copy link
Collaborator

@cjee21 cjee21 commented Jul 2, 2024

  • Remove unused donate buttons and related code
  • Organize GUI_Main.cpp
    • Move functions to the appropriate sections and improve some comments for easier finding and understanding in the future
  • Upgrade open file dialog
    • Use the same dialog type for opening files as the one for opening folders
    • Should not have visible difference since old dialog is auto upgraded by VCL at runtime to new one when running on Windows Vista+
    • This change is for consistency with folder open dialog and maybe make it more efficient by dropping support of old dialog
    • The new dialogs work on Windows Vista+
  • Partial fix for 2nd issue of 24.06 - Open Preferences and click on "Adavanced" -> GUI buttons appear #891
    • The GUI is now properly displayed following user preferences when Preferences window is closed
    • The issues that happen when Preferences->Advanced is opened remains
  • Fix the file selector button in Export window is too big at high-DPI
    • Similar to recent changes for buttons in Main and Preferences windows

@JeromeMartinez
Copy link
Member

Thank you for the clean up!

@JeromeMartinez JeromeMartinez merged commit d1018e7 into MediaArea:master Jul 2, 2024
3 checks passed
@cjee21 cjee21 deleted the clean-up branch July 2, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants