Display AE in 1 page #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 17, 2024 10:18
…teractive forest table
There was a problem hiding this comment.
Thank you so much, @shgeng1216! I understand it is not easy to get all the CMD check pass, and we appreciate your time overcoming all challenging. I only have 1 minor comment below.
Merge branch 'main' of https://github.com/Merck/forestly into displayAEin1Page # Conflicts: # R/ae_forestly.R # man/ae_forestly.Rd
|
Is there a particular reason you want to limit customizing the page size options to only the maximum number instead of an arbitrary vector of numbers, like how reactable originally supports it? |
nanxstats
requested changes
May 27, 2024
nanxstats
approved these changes
May 30, 2024
|
OK! It looks like you have strong reasons to make this change, which I fully understand. So let's get it merged. Thanks again for adding this new feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add max_page argument to control the max page number showed in the interactive forest table