Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add vignette on meta_forestly() #53

Merged
merged 10 commits into from
May 29, 2024
Merged

Add vignette on meta_forestly() #53

merged 10 commits into from
May 29, 2024

Conversation

yuliasidi
Copy link
Collaborator

To clarify the addition of different parameters, including completely new parameters (dose reduction example)

yuliasidi and others added 5 commits May 10, 2024 15:38
data updated to have tox grades and action taken.
2179555 
draft vignette added
update
9a25db3
merge from upstream/main
9e74292 
Merge branch 'main' into 20_forestly_metalite_vign

# Conflicts:
#	vignettes/meta_forestly.Rmd
meta_forestly vignette was finalized
5117572
@yuliasidi
Merge pull request #3 from yuliasidi/20_forestly_metalite_vign
ab0a034 
20 forestly metalite vignette was added
nanxstats
nanxstats requested changes May 20, 2024
View reviewed changes
vignettes/meta_forestly.Rmd Outdated Show resolved Hide resolved
vignettes/meta_forestly.Rmd Outdated Show resolved Hide resolved
vignettes/meta_forestly.Rmd Outdated Show resolved Hide resolved
vignettes/meta_forestly.Rmd Outdated Show resolved Hide resolved
vignettes/meta_forestly.Rmd Outdated Show resolved Hide resolved
vignettes/meta_forestly.Rmd Outdated Show resolved Hide resolved
@yuliasidi yuliasidi requested a review from nanxstats May 22, 2024 17:14
@nanxstats
Copy link
Collaborator

To make this pass R CMD build, simply attach the datasets before using them in the vignette:

data(forestly_adsl)
data(forestly_adae)

To avoid the R CMD check note saying "sub-directories of 1Mb or more", add this line to .Rbuildignore:

^vignettes/meta-forestly.Rmd$

nanxstats
nanxstats requested changes May 23, 2024
View reviewed changes
vignettes/.gitignore Outdated Show resolved Hide resolved
@nanxstats nanxstats merged commit fcaccdb into Merck:main May 29, 2024
7 checks passed
@nanxstats
Copy link
Collaborator

It's up: https://merck.github.io/forestly/articles/meta-forestly.html

@nanxstats nanxstats changed the title vignette on meta_forestly Add vignette on meta_forestly() May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nanxstats nanxstats nanxstats approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuliasidi @nanxstats