Update navbar style for pkgdown >= 2.1.0 #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the navbar link style in
extra.cssto accommodate the HTML class name changes in pkgdown 2.1.0 (due to the new option to have light/dark themes).This would restore the navbar look and feel under pkgdown < 2.1.0. Without this change, when rendering with pkgdown >= 2.1.0, the navbar link hover and active state color contrast will be too low.
Also runs pkgdown locally to store the
pkgdown/favicon/so that these static assets don't have to be regenerated live every time the site is built on GitHub.