Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove seed setting and replace \dontrun{} with \donttest{} #55

Merged
merged 5 commits into from
Dec 20, 2024

Conversation

fukuhiro2023
Copy link
Collaborator

This PR updates:

  • meta_sl_example() to remove seed setting.
  • rtf_base_char_subgroup to replace \dontrun{} with \donttest{}.

Also, cran-comments.md is added.
These are based on the CRAN's feedback for v0.1.0 release as below:

\dontrun{} should only be used if the example really cannot be executed (e.g. because of missing additional software, missing API keys, ...) by the user. That's why wrapping examples in \dontrun{} adds the comment ("# Not run:") as a warning for the user. Does not seem necessary.
Please replace \dontrun with \donttest.
Only functions which are supposed to only run interactively (e.g. shiny) should be wrapped in if(interactive()). Please replace if(interactive()){} if possible.

Please do not set a seed to a specific number within a function. -> R/meta_sl_example.R

Copy link
Collaborator

@wangben718 wangben718 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Please upload it again when you have time.

@wangben718 wangben718 merged commit f9f4612 into main Dec 20, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants