-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamic repository #377
base: main
Are you sure you want to change the base?
Dynamic repository #377
Conversation
I just saw this PR, and I have several huge issues with it:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As indicated in my comment, this PR should be split into two (change to testing, then the rest), and be based on the develop branch. I would also like to have a discussion about the direction this refactoring is going, e.g. moving files out of the tools directory kind of breaks this subdirectory, since it now needs outside imports.
Rather than requiring double-entry book-keeping use introspection to automatically build up the list of tools.
This change involves moving everything which is not a tool out of the tool directory.
Also, since the fundamental job of fab is to shell out to executables it seems like a good idea to use a dedicated pytest extension for mocking the subprocess system rather than doing it ad-hoc each time.