Added support for namespaced vuex modules #242
+334
−461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the modifications for supporting namespaced Vuex modules. In earlier versions the system ignored namespaces on the store but kept the full path of the incoming event. Now if a prefix exists, it is parsed into the key path after the last separator.
Additionally, some changes were made to align with the documentation specifying that prefixes are purely optional and if not specified would default to null. This has been corrected for both actions and mutations. The readme has been updated to reflect all changes.
Edit: Rolled back changes by @focux in commit 8988085 due to inconsistencies in the documentation and numerous breaking changes. I'd recommend reviewing these past changes and recommitting them when properly tested and evaluated for all potential cases.