Send Authorized API Requests #10
Merged
+44
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you're adding in credentials can you update the ratelimit to match. I would probably drop it down to a per minute instead of 2000/day. |
I'm planning to do that in a separate PR, since it makes sense to use a more robust rate limiting solution, that will allow setting a per day and a per hour or minute value, while also tracking it between sessions. I'm just waiting to hear back the GCD devs on what value they want us to use. |
Buried-In-Code
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds authorization to API request using the user's GCD email & password.
Anonymous usage is dropped, since 30 per hour isn't terribly useful, and code-wise it isn't really workable with the current rate-limiting method.