Add configuration options for notification urgency #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thoughts? I've been using my fork for a while now, seems fine. |
niraami
force-pushed
the
configurable-notification-urgency
branch
from
e81d562 to
7a2adb1
Compare
|
Been a year, rebased the changes 2 months ago so they no longer conflict. If you don't like the change just close the PR so I don't have to care about this anymore. |
|
Hi @niraami sorry for the radio silence but I've had less time to maintain this repo dur to life commitments. The changes look good in principle - I just need to find some time to review and test them. I'll probably have some time during the holiday period. |
|
No worries, glad to hear it nevertheless. I've been using my fork on all of my machines since I made the PR, so I don't think I can test it any more than I already have :P |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds upon and replaces #24
Gives the user access to 2 configuration options that affect what urgency is used for the notification.
AUTO_NOTIFY_URGENCY_ON_SUCCESSAUTO_NOTIFY_URGENCY_ON_ERRORI've also added a test case for the
ON_SUCCESSurgency option. I was unfortunately not able to figure out how to add a test case for theON_ERRORoption without modifying unrelated parts of the code quite heavily.I've also added a section in the README, but I'm unfamiliar with the formatting, and my VS Code extension is not rendering it properly, so I just copied the style and hope it works :)