Add AUTO_NOTIFY_SOUND env var to provide sound option
#55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MichaelAquilina |
|
Pretty cool! I tested it and it worked. |
V4G4X
reviewed
Mar 18, 2024
auto-notify.plugin.zsh
Outdated
Comment on lines
65
to
77
| if [[ -z "$AUTO_NOTIFY_SOUND" ]]; then | ||
| osascript \ | ||
| -e 'on run argv' \ | ||
| -e 'display notification (item 1 of argv) with title (item 2 of argv)' \ | ||
| -e 'end run' \ | ||
| "$body" "$title" | ||
| else | ||
| osascript \ | ||
| -e 'on run argv' \ | ||
| -e 'display notification (item 1 of argv) with title (item 2 of argv) sound name (item 3 of argv)' \ | ||
| -e 'end run' \ | ||
| "$body" "$title" "$AUTO_NOTIFY_SOUND" | ||
| fi |
There was a problem hiding this comment.
Not too well-versed with shell scripting.
But is it possible to extract the common command line arguments here out?
Something like?
Suggested change
| if [[ -z "$AUTO_NOTIFY_SOUND" ]]; then | |
| osascript \ | |
| -e 'on run argv' \ | |
| -e 'display notification (item 1 of argv) with title (item 2 of argv)' \ | |
| -e 'end run' \ | |
| "$body" "$title" | |
| else | |
| osascript \ | |
| -e 'on run argv' \ | |
| -e 'display notification (item 1 of argv) with title (item 2 of argv) sound name (item 3 of argv)' \ | |
| -e 'end run' \ | |
| "$body" "$title" "$AUTO_NOTIFY_SOUND" | |
| fi | |
| notification_body := "$body" "$title" | |
| if [[ ! -z "$AUTO_NOTIFY_SOUND" ]]; then | |
| notification_body += ("$AUTO_NOTIFY_SOUND") | |
| else | |
| osascript \ | |
| -e 'on run argv' \ | |
| -e 'display notification (item 1 of argv) with title (item 2 of argv) sound name (item 3 of argv)' \ (OPTIONAL CONCAT HERE AS WELL) | |
| -e 'end run' \ | |
| ${notification_body[@]} |
There was a problem hiding this comment.
Thank you for suggestion. I'm not sure if i get it right but made changes. Check it out please!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this is my first issue to zsh-auto-notify. I hope you liked this.