Entity data mining #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4everTheOne
commented
Sep 1, 2024
| jsonObject.add("angry", camelSitting); | ||
| } | ||
|
|
||
| // TODO: Player - Sneaking, Gliding, Swimming, Sleeping |
There was a problem hiding this comment.
The logic for Player is missing:
- Sneaking
- Gliding
- Swimming
- Sleeping
Thorinwasher
reviewed
Sep 2, 2024
Comment on lines
29
to
39
| BigDecimal normalWidth = BigDecimal.valueOf(mojangEntityType.getWidth()); | ||
| BigDecimal normalHeight = BigDecimal.valueOf(mojangEntityType.getHeight()); | ||
| BigDecimal normalEyeHeight = BigDecimal.valueOf(mojangEntityType.getDimensions().eyeHeight()); | ||
|
|
||
| BigDecimal babyWidth = normalWidth.multiply(scale); | ||
| BigDecimal babyHeight = normalHeight.multiply(scale); | ||
| BigDecimal babyEyeHeight = BigDecimal.ZERO; | ||
| if (BigDecimal.ZERO.compareTo(normalHeight) != 0) | ||
| { | ||
| babyEyeHeight = babyHeight.multiply(normalEyeHeight).divide(normalHeight, RoundingMode.HALF_UP); | ||
| } |
There was a problem hiding this comment.
Why do you convert from float to big decimal and then back to double. From my knowledge this should be fine by just converting directly from double, if theres a reason behind this? Floating point precission?
There was a problem hiding this comment.
It's mostly related with the precision in the divisions and multiplication. Because when i attempted to do the maths with the double, the values were off by a significant margin. And when copying the generated files to the mockbukkit project it would replace the correct values with the "bad values".
- Refactored Base Damage in arrows - Added support for Base Damage in arrows
|
It's now ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to automatically mine entity data from the source code. This PR is related with MockBukkit/MockBukkit#1101.
This implementation extracts: