Remove default tablet keybind #32
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR retains the keybind for opening the shard tablet, but removes the default "J" key setting.
Motivation
If someone drops this mod into a pack without configuring it, I don't want us to create or contribute to a situation where players feel that the keyboard is full of useless keybinds, and that they can't bind a function they actually want because they don't know what they can safely unbind. I have run into this situation a lot, and the solution is for us devs to stop thinking that ours is the special keybind that nobody can live without. The sensible default for most keys is unbound, and it's up to pack makers to pick the ones that are most vital for their players.
Impact
For ModFest / Blanketcon, I anticipate that we will ship a "J" keybind in the pack and nothing will change for users.
Other Details
When a key is bound, the existing toast shows, e.g. "Press [J] to view"
When no key is bound (the new default), the toast now shows "Use /shards to view"
As requested, I've included a note in the readme, letting users and packmakers know that a keybind is available.