feat: composite rules #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dafyh
reviewed
Oct 19, 2023
Dafyh
reviewed
Oct 19, 2023
Dafyh
reviewed
Oct 19, 2023
fraxken
approved these changes
Oct 22, 2023
Dafyh
approved these changes
Oct 23, 2023
Theses changes allow to have each notifier handle its own data (aot) instead of have a big one mess notifier. TODO: Self Monitoring test "should have throttle" is flaky.
PierreDemailly
force-pushed
the
composite-rules
branch
from
05e4e47 to
8f71f4b
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I still have some things to improve but a first review would be welcome :)
Note:
notifiedCountis a placeholder