Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(config): split utils #144

Merged
merged 1 commit into from
Nov 9, 2023
Merged

refactor(config): split utils #144

merged 1 commit into from
Nov 9, 2023

Conversation

PierreDemailly
Copy link
Member

Theses changes also fixes a bug with rules & compositeRules notifiers:

rule.notifiers ??= Object.values(config.notifiers!).map(({ notifier }) => notifier);

instead of rule.notifiers ??= Object.keys(config.notifiers!)

Due to the new notifier property.

@PierreDemailly PierreDemailly merged commit 158f082 into main Nov 9, 2023
5 checks passed
@PierreDemailly PierreDemailly deleted the split-config-utils branch November 9, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants