Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update @openally/config.eslint #335

Merged
merged 1 commit into from
Jan 5, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 24 additions & 30 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"src/pattern"
],
"devDependencies": {
"@openally/config.eslint": "^1.1.0",
"@openally/config.eslint": "^1.3.0",
"@openally/config.typescript": "^1.0.3",
"@types/node": "^22.10.5",
"c8": "^10.1.3",
Expand Down
4 changes: 2 additions & 2 deletions src/agent/src/notifiers/notifier.ts
Original file line number Diff line number Diff line change
Expand Up @@ -59,11 +59,11 @@ export class Notifier<T extends Alert> {
);
}

protected sendNotification(alert: T): void {
protected sendNotification(_alert: T): void {
throw new Error("sendNotification must be implemented");
}

protected nonUniqueMatcher(notification: T, newNotifications: T): boolean {
protected nonUniqueMatcher(_notification: T, _newNotifications: T): boolean {
throw new Error("nonUniqueMatcher must be implemented");
}

Expand Down
2 changes: 1 addition & 1 deletion src/logql/src/labelFilters.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ export interface LabelFilter {
operator: LabelFilterOperator;
}

export type LabelValue = Partial<LabelFilter> & Pick<LabelFilter, "value">
export type LabelValue = Partial<LabelFilter> & Pick<LabelFilter, "value">;

export class LabelFilters extends Map<string, LabelFilter[]> {
static removeStreamSelector(query: string) {
Expand Down
2 changes: 1 addition & 1 deletion src/logql/src/streamSelector.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ export interface StreamSelectorValue {
}

export type LabelValue = Partial<StreamSelectorValue> & Pick<StreamSelectorValue, "value">;
export type StreamSelectorOp = { [kEqual]?: string | RegExp } | { [kNotEqual]?: string | RegExp };
export type StreamSelectorOp = { [kEqual]?: string | RegExp; } | { [kNotEqual]?: string | RegExp; };

export class StreamSelector extends Map<string, StreamSelectorValue> {
static Equal(value: string | RegExp) {
Expand Down
2 changes: 1 addition & 1 deletion src/logql/test/logql.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ describe("LogQL", () => {

it("should parse a LogQL with lineFilter, labelFilter and parseExpression", () => {
const logql = new LogQL(
// eslint-disable-next-line max-len
// eslint-disable-next-line @stylistic/max-len
`{app="discussion",env="production"} |= "returned "GET /rooms/availableUsers" | regexp \`((?P<execTime>[0-9.]+)ms)\` | execTime > 500`
);

Expand Down
Loading