Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#13338 Add support for playback of requested Live TV channel from Frontend Services API #173

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

JRRandall
Copy link

Thank you for contributing to MythTV.

As many of our developers do not visit GitHub it is important to track
all contributions at our central ticket tracker over at code.mythtv.org

To prevent your contributions being overlooked please create a new ticket
there and refer to this pull request. (Bonus points for linking to the
ticket in the pull request, too. It helps us noticed potentially overlooked
pull requests due to missing tickets.)

https://code.mythtv.org/trac/wiki/TicketHowTo
https://code.mythtv.org/trac/newticket

@JRRandall
Copy link
Author

Needs to be tested. Simple change to extend the Frontend Services API with a method for requesting Live TV playback tuned to a specific channel ID.

  • Makes sure requested ChanID is "valid" i.e. non-negative, non-zero.
  • Checks current state of frontend GUI and attempts to change to Live TV.
  • If current state is Live TV then requested channel identifier passed to network control for tuning.

@JRRandall
Copy link
Author

This is the ticket for this pull request. https://code.mythtv.org/trac/ticket/13338

@JRRandall JRRandall changed the title Add support for playback of requested Live TV channel from Frontend Services API #13338 Add support for playback of requested Live TV channel from Frontend Services API May 7, 2019
@stuarta stuarta added component:mythtv:api Services API issues patch:feature This patch implements a new feature version:master Master Development Branch labels Aug 25, 2021
@bennettpeter
Copy link
Member

1). I get compile errors

services/frontend.cpp: In member function ‘virtual bool Frontend::PlayLiveTV(int)’:
services/frontend.cpp:206:37: error: ‘jumpMap’ was not declared in this scope
  206 |         GetMythMainWindow()->JumpTo(jumpMap["Live TV"]);
      |                                     ^~~~~~~
services/frontend.cpp:210:35: error: ‘FE_LONG_TO’ was not declared in this scope
  210 |         while ((timer.elapsed() < FE_LONG_TO) &&
      |                                   ^~~~~~~~~~

2). There is already a frontend service that starts Live TV, but always in the last channel played:
http://rocinante:6547/Frontend/SendAction?Action=Live%20TV
There is an optional Value already in that service, not used for Live TV, that could be used for passing in a channum or chanid. This is another way this functionality may be able to be added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:mythtv:api Services API issues patch:feature This patch implements a new feature version:master Master Development Branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants