Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window center, minimum and maximum #139

Conversation

Zack-83
Copy link
Collaborator

@Zack-83 Zack-83 commented Sep 13, 2024

Solves #131
Solves #88

src/templates/vibso_classes.tsv Outdated Show resolved Hide resolved
src/templates/vibso_classes.tsv Outdated Show resolved Hide resolved
src/templates/vibso_classes.tsv Outdated Show resolved Hide resolved
@Zack-83 Zack-83 requested a review from StroemPhi September 16, 2024 12:42
Copy link
Member

@StroemPhi StroemPhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just saw that we need to update the parent as well

src/templates/vibso_classes.tsv Outdated Show resolved Hide resolved
src/templates/vibso_classes.tsv Outdated Show resolved Hide resolved
src/templates/vibso_classes.tsv Outdated Show resolved Hide resolved
Zack-83 and others added 2 commits September 16, 2024 15:32
@StroemPhi StroemPhi merged commit c670bb6 into main Sep 17, 2024
1 check passed
@StroemPhi StroemPhi deleted the 131-improve-definitions-of-spectral-window-range-maximum-spectral-window-range-minimum branch September 17, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve definitions of 'spectral window range maximum' & 'spectral window range minimum'
2 participants