-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(module:anchor): url fragment change on click - nzReplace #8464
base: master
Are you sure you want to change the base?
feat(module:anchor): url fragment change on click - nzReplace #8464
Conversation
This preview will be available after the AzureCI is passed. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8464 +/- ##
==========================================
- Coverage 91.83% 91.81% -0.02%
==========================================
Files 548 548
Lines 19310 19320 +10
Branches 2862 2865 +3
==========================================
+ Hits 17733 17739 +6
- Misses 1261 1262 +1
- Partials 316 319 +3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
unit tests failed with error, please solve this issue first @ParsaArvanehPA anchor property (nzChange) should emit nzChange when scrolling to the anchor |
…ttps://github.com/ParsaArvanehPA/ng-zorro-antd into feature/anchor-navigation-without-location-change
@ParsaArvanehPA I had tried to fix this CI issue, but all my efforts didn't work. Your previous workaround which is to multiply the throttleTime by 20 FAILs. |
Thanks @Laffery |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
replace
option that Ant provides.What is the new behavior?
Does this PR introduce a breaking change?
Other information