add real-scorecard to MONET #227
Conversation
update real-scorecard
more better or worse method
added regulatory feature in multi-region boxplot
update mutlibox plot regulatory option with pandas merge
There was a problem hiding this comment.
The real-scorecard updates and description look good here. My concern is it looks like the multi-boxplot stuff is also in this pull request. But this already got merged to develop and I think is what is causing the merge conflicts in this pull request. @zmoon do you have suggestions to Beiming on how to fix this within GitHub, so this pull request only updates the scorecard components?
|
@btang1 you mentioned last week that this was ready, but it looks like there are still merge conflicts? I can review this Thurs/Fri next week. Just let me know when it is ready. |
Thanks will address the merge problem! |
Conflicts: docs/appendix/yaml.rst docs/examples/airnow_wrfchem.ipynb docs/examples/control_wrfchem_mech-0905_2.yaml melodies_monet/driver.py melodies_monet/plots/surfplots.py
|
@btang1, this looks good. Although GitHub still says there are some merge conflicts that need to be resolved before merging. Can you update these and then I can merge this in? I don't see any more problems with the multi-boxplot, so maybe these are other problems? |
|
Maybe this is because I merged in your other pull request. And this caused some conflicts with this code now? |
@rschwant Yes! the scorecard has incorporate most multi-box plot code. but not CSI code yet. So once you merge CSI code. The scorecard code has merging problem again. no worries. I will try to fix it~ |
…card Conflicts: docs/appendix/yaml.rst docs/examples/airnow_wrfchem.ipynb melodies_monet/driver.py melodies_monet/plots/surfplots.py
|
@rschwant Hi Becky, I have merged changes from CSI to scorecard. and test it example output in: https://github.com/btang1/MELODIES-MONET/blob/real-scorecard/docs/examples/airnow_wrfchem.ipynb. |
|
@btang1 Just to add this here too. Can you fix the error in this file? https://github.com/btang1/MELODIES-MONET/blob/real-scorecard/docs/examples/airnow_wrfchem.ipynb. It looks like for the csi plot, you do not define a region_bx, so it shouldn't be listed on line 1989 to delete? Probably when you did the merge fix this did not merge perfectly. So I think you need to delete "region_bx" from this line and re-run. |
add real-score card to MONET
note #219 should be merged before this