Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs env #299

Merged
merged 7 commits into from
Nov 9, 2024
Merged

Update docs env #299

merged 7 commits into from
Nov 9, 2024

Conversation

zmoon
Copy link
Collaborator

@zmoon zmoon commented Oct 22, 2024 •
edited
Loading

We could also update the docs to recommend Python 3.10 3.11 instead of 3.9? @rschwant

@zmoon zmoon requested a review from rschwant October 25, 2024 18:34
rschwant
rschwant approved these changes Nov 4, 2024
View reviewed changes
Copy link
Collaborator

@rschwant rschwant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to update the environment. And I'm happy to move to later versions of Python because we can test the code with this now too.

@zmoon zmoon requested a review from rschwant November 4, 2024 22:52
@zmoon
pytest summary all except passed
ad1eaa0 
-rsx doesn't include failed
rschwant
rschwant approved these changes Nov 8, 2024
View reviewed changes
Copy link
Collaborator

@rschwant rschwant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Great!

@zmoon zmoon merged commit 37e6234 into NOAA-CSL:develop Nov 9, 2024
5 checks passed
@zmoon zmoon deleted the update-rtd branch November 9, 2024 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rschwant rschwant rschwant approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zmoon @rschwant