Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plot postprocessed ice concentration increment #1446

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

shlyaeva
Copy link
Collaborator

@shlyaeva shlyaeva commented Jan 15, 2025

Description

Add plots to offline vrfy to output postprocessed (aka what get added to CICE restart) sea ice increment.

Companion PRs

NOAA-EMC/jcb-gdas#64
NOAA-EMC/global-workflow#3235

Issues

Resolves #1402

Automated CI tests to run in Global Workflow

Since it's offline vrfy, no tests would cover it currently.

  • atm_jjob
  • C96C48_ufs_hybatmDA
  • C96C48_hybatmaerosnowDA
  • C48mx500_3DVarAOWCDA
  • C48mx500_hybAOWCDA
  • C96C48_hybatmDA

Copy link
Contributor

@guillaumevernieres guillaumevernieres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I'll wait for @apchoiCMD 's review before merging.

Copy link
Collaborator

@apchoiCMD apchoiCMD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No doubt and thanks @shlyaeva

@shlyaeva
Copy link
Collaborator Author

Please wait on merging: this also requires global-workflow PR; I'm running some final sanity check tests and will push it soon!

@shlyaeva
Copy link
Collaborator Author

shlyaeva commented Jan 16, 2025

I've opened NOAA-EMC/global-workflow#3235.

The dependencies are:

I am not sure what this means in terms of what should be merged in what order, happy for someone else to decide 😆 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add diagnostic for the "actual" sea ice increment
3 participants