Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify RadMon plotting to change regional periods #152

Merged

Conversation

EdwardSafford-NOAA
Copy link
Collaborator

Modify RadMon plotting to support regional sources with 24 cycles per day including these specific changes:

  • Make 1 day = 24 cycles (global is 4/day)
  • Make the maximum span 5 days (120 cycles)
  • Change to index.html.glb is unrelated; it's just removal of code that's been commented out for years and has never been used. I just spotted it in the course of this work and decided to finally remove it.

Testing has been done with both regional (nam) data and global (gfs) data. Global results are unchanged, regional now plot with the periods defined above.

Closes #128

Fix regional angle & time file generation, generalize all file writes.
Rm diagnostic output.
Merge branch 'develop' into bug/rgn-data-128
Add changes to image gen to support regional 24 cyc/day.
Rm block on file cleanup (used testing purposes), clarify code comments.
Copy link
Collaborator

@xyzemc xyzemc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good.

@EdwardSafford-NOAA EdwardSafford-NOAA merged commit ec12cad into NOAA-EMC:develop Jan 15, 2025
4 checks passed
@EdwardSafford-NOAA EdwardSafford-NOAA deleted the feature/rrfs-128 branch January 15, 2025 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some RadMon extracted data for regional sources is missing and/or incorrect
2 participants