Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CODEOWNERS file #594

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Update CODEOWNERS file #594

merged 1 commit into from
Jan 16, 2025

Conversation

MatthewPyle-NOAA
Copy link
Contributor

Attempt to correct the default reviewers for a PR.

DESCRIPTION OF CHANGES:

  • Updates the .github/CODEOWNERS file, removing Jacob and Chan-Hoo, and adding Lin Gan.

TESTS CONDUCTED:

Machines/Platforms:

  • WCOSS2
    • Cactus/Dogwood
    • Acorn
  • RDHPCS
    • Hera
    • Jet
    • Orion
    • Hercules

Test cases:

  • Engineering tests
    • Non-DA engineering test
    • DA engineering test
      • Retro
      • Ensemble
      • Parallel
  • RRFS fire weather
  • RRFS_A:
  • RRFS_B:
  • RTMA:
  • Others:

ISSUE:

CONTRIBUTORS (optional):

@MatthewPyle-NOAA
Update CODEOWNERS
1b73db1 
Attempt to correct the default reviewers for a PR.
@MatthewPyle-NOAA MatthewPyle-NOAA changed the title Update CODEOWNERS Update CODEOWNERS file Jan 16, 2025
BenjaminBlake-NOAA
BenjaminBlake-NOAA approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@BenjaminBlake-NOAA BenjaminBlake-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised Chan-Hoo's name was still in there. :)

@MatthewPyle-NOAA MatthewPyle-NOAA merged commit 3cffb41 into main Jan 16, 2025
2 checks passed
@MatthewPyle-NOAA
Copy link
Contributor Author

Yes @BenjaminBlake-NOAA when I edited it it was showing his name as an error, since he doesn't have rrfs-workflow privileges now.

@MatthewPyle-NOAA MatthewPyle-NOAA deleted the MatthewPyle-NOAA-patch-1 branch January 16, 2025 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenjaminBlake-NOAA BenjaminBlake-NOAA BenjaminBlake-NOAA approved these changes

@ShunLiu-NOAA ShunLiu-NOAA Awaiting requested review from ShunLiu-NOAA ShunLiu-NOAA is a code owner

@JacobCarley-NOAA JacobCarley-NOAA Awaiting requested review from JacobCarley-NOAA

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MatthewPyle-NOAA @BenjaminBlake-NOAA