added obc generation workflow #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uwagura
reviewed
Dec 20, 2024
|
@uwagura , thank you for your comments. I have addressed most of them. Please feel free to review them again. |
github-actions
bot
added
pass_CEFI_MOM6_RT_container
and removed
CEFI_MOM6_RT_container
labels
uwagura
approved these changes
Dec 30, 2024
|
Thanks for this workflow! One minor suggestion: I have had trouble in the past with xarray interpreting and resetting datetimes so I usually set "decode_times=False" for xarray.open_dataset or "decode_cf=False" for xarray.open_mfdataset in the write_boundary python script to prevent modification of the time variable. I then have a few ncatted lines at the end of the script to ensure it has GLORYS-consistent metadata. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by #126 and Andrew's original Python script for OBC generation, we have provided an example workflow as well as templates for the entire OBC generation process using the GLORYS data. @uwagura, it's still a work in progress, but you can take a look when you get a chance.