+Refactor MOM_opacity to replace hard-coded params #775
+119
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored MOM_opacity to replace hard-coded dimensional parameters for the Manizza and Morel opacity fits with run-time parameters. By default, these parameters are set to the previous hard-coded values, using the recently added defaults argument to get_param_real_array(). The bounds of the frequency band label arrays with the MANIZZA_05 opacity scheme were also corrected when PEN_SW_NBANDS > 3, but it would not by typical to use so many bands for no purpose and these labeling arrays (optics%min_wavelength_band and optics%max_wavelength_band) do not appear to be used anywhere. In addition, the unused publicly visible routines opacity_manizza and opacity_morel were eliminated or made private. All answers are bitwise identical, but there are new entries in some MOM_parameter_doc files.
Hallberg-NOAA
added
the
Parameter change
raphaeldussin
suggested changes
Jan 8, 2025
| CS%opacity_coef(2,n) * chl_data(i,j)**CS%chl_power(n) | ||
| enddo | ||
| do n=CS%chl_dep_bands+1,optics%nbands ! These bands do not depend on the chlorophyll. | ||
| optics%opacity_band(n,i,j,k) = CS%opacity_coef(1,n) |
There was a problem hiding this comment.
since the formulation does not allow for a coef_2 or chl power for near IR bands, I suggest to put a FATAL if the use tries to put a value different from zero in opacity_coefs[6] or opacity_powers[3]
| do n=3,optics%nbands | ||
| optics%min_wavelength_band(n) =700 | ||
| optics%max_wavelength_band(n) =2800 | ||
| optics%min_wavelength_band(n) = 700. + (n-3)*2100.0*I_NIR_bands |
There was a problem hiding this comment.
should hardcoded values also be parameters?
| if (.not.allocated(optics%min_wavelength_band)) & | ||
| allocate(optics%min_wavelength_band(optics%nbands)) | ||
| if (.not.allocated(optics%max_wavelength_band)) & | ||
| allocate(optics%max_wavelength_band(optics%nbands)) | ||
|
|
||
| ! Set opacity scheme dependent parameters. | ||
| if (CS%opacity_scheme == MANIZZA_05) then | ||
| optics%min_wavelength_band(1) =0 |
There was a problem hiding this comment.
this could be close to 300nm unless we want to include gamma rays and UV
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored
MOM_opacityto replace hard-coded dimensional parameters for the Manizza and Morel opacity fits with run-time parameters. By default, these parameters are set to the previous hard-coded values, using the recently added defaults argument toget_param_real_array(). The bounds of the frequency band label arrays with theMANIZZA_05opacity scheme were also corrected whenPEN_SW_NBANDS > 3, but it would not by typical to use so many bands for no purpose and these labeling arrays (optics%min_wavelength_bandandoptics%max_wavelength_band) do not appear to be used anywhere. In addition, the unused publicly visible routinesopacity_manizza()andopacity_morel()were eliminated or made private. All answers are bitwise identical, but there are new entries in someMOM_parameter_docfiles.