add aerosol related updates

[bbakernoaa]

This closes #160

Main updates were in the template.py and _grib2io.py files. More improvement could be completed later but it does produce a grib2 message now with unique shortNames and fullNames for each variable now.

Additionally the xarray backend works as well.

[bbakernoaa]

@zmoon

[bbakernoaa]

This is still in a draft mode. Please don't merge yet

[bbakernoaa]

This should be ready now.

[bbakernoaa]

ok should be good to go. More work is needed but this at least adds the capability for GEFS-Aerosols and RRFS to properly read the variables and assign unique variable names to each aerosol species.

[zmoon]

Just some cleanup comments. Also maybe the aerosol-specific get short/full name sections could be extracted to their own function/method.

[EricEngle-NOAA]

How is this coming along? Do you think it is ready to merge?

[bbakernoaa]

Yes I believe it is ready to go. This actually led us to find an error in the way they were assigning a grib variable in the RRFS prototype too. They were assigning the aerosol type as "Missing" for some of their species instead of total or 62000

[EricEngle-NOAA]

Forgot to post these questions from my review a few days ago. Apologies.

[bbakernoaa]

@EricEngle-NOAA Anything you want me to do to get this merged?

[EricEngle-NOAA]

@bbakernoaa can you create a test for this? See the tests/ dir at the repo root. We are using pytest. Also feel free to add a GEFS chem file to tests/data/, but thin the grid to 1.0 deg to keep a smaller file size.

[EricEngle-NOAA]

I think a test to make sure the shortName and fullName are properly constructed is good enough. That is all that this PR is for so no need to test data unpacking etc.

[bbakernoaa]

Ok will do. I added the 2d data file here but may also add one for the 3d data

[EricEngle-NOAA]

Any updates regarding a test?

[bbakernoaa]

Sorry I got swamped with some other things. I’ll get something next week after AGU Barry Baker National Oceanic and Atmospheric Administration Air Resources Laboratory Physical Research Scientist Chemical Modeling and Emissions Group Leader NCWCP, R/ARL, Rm. 4204 5830 University Research Court College Park, Maryland 20740 Phone: ‪(301) 683-1395‬

…

On Mon, Dec 9, 2024 at 10:46 AM Eric Engle ***@***.***> wrote: Any updates regarding a test? — Reply to this email directly, view it on GitHub <#161 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFIUVN2ZO45LXE72FXZA5VL2EW3OTAVCNFSM6AAAAABRZZ77DCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMRYGQ2TINRWHA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[EricEngle-NOAA]

@bbakernoaa - No problem. Thanks for the update.

[EricEngle-NOAA]

Hi @bbakernoaa - Any update on this?

[bbakernoaa]

@EricEngle-NOAA please take a look and let me know if that test works

[bbakernoaa]

@EricEngle-NOAA Sorry removed an unused import that snuck in.

[EricEngle-NOAA]

Thanks @bbakernoaa and sorry for being a pain. I might do some moving around of what you added.

[bbakernoaa]

please do!

[bbakernoaa]

@EricEngle-NOAA I noticed the gefs grib file is in the base directory along with in the tests/data directory. We should probably remove the one in the base directory

[EricEngle-NOAA]

I did move it under tests/data/ in the commit I am working on.

[bbakernoaa]

Awesome, thanks! Barry Baker National Oceanic and Atmospheric Administration Air Resources Laboratory Physical Research Scientist Chemical Modeling and Emissions Group Leader NCWCP, R/ARL, Rm. 4204 5830 University Research Court College Park, Maryland 20740 Phone: ‪(301) 683-1395‬

…

On Wed, Jan 22, 2025 at 11:42 AM Eric Engle ***@***.***> wrote: I did move it under tests/data/ in the commit I am working on. — Reply to this email directly, view it on GitHub <#161 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFIUVN7XE4MQ6EE2J6XFUND2L7C5LAVCNFSM6AAAAABRZZ77DCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMBXG4ZTQMZWG4> . You are receiving this because you were mentioned.Message ID: ***@***.***>