waves_example notebook was broken with dev code #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LCOE breakdown method for annual workflows
* energy_loss update * fix line lengths, typos, typing, and add input. * environmental_loss_ratio, detailed wake_losses, eliminate with_losses * add missing docstring and run pre-commit * fix error message * fix verbose bool check * fix typo in cable naming * update for ORBIT v1.1 compatibility * fix missing turbine potential bug in timeseries * apply intended changes and bug fixes to wake_losses * fix remaining floris energy potential/production method issues * update error message * Addressed feedback from RHammond2: energy_losses = potential * total_loss_ratio and descriptive note for total_loss_ratio method * udpate pre-commit configuration * shorten argument and run pre-commit * remove redundancies and fix small calculation issues * fix small computation and aggregation bugs * update wake losses for potential * update technical losses for unavailable land option * update changelog * add input validation and common floris energy capture method * update remaining metrics with validator decorator * update changelog --------- Co-authored-by: RHammond2 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a few errors that needed to be fixed to run the waves_example notebook.