Generation max_workers defaults to None if omitted from config file

[ppinchuk]

Mostly a QOL change - it has no impact if the user explicitly specifies max_workers in their config file. However, if the user omits this input from their config file altogether, the default value is set to None instead of 1. The default value for the API is still 1.

[grantbuster]

Nice way to preserve the config default vs. python default, but where does the max_workers=None default get set? I see that .setdefault() call but does that assume None? Is there a corresponding GAPs PR?

[ppinchuk]

Yea the setdefault() function will add the key to the dictionary if it's missing with a value of None by default. If the key is in the dictionary, the function just returns the value and leaves the dictionary unchanged.

No need for any new GAPs functionality - we simply perform a pre-processing check on the config and force a default value if needbe.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2763063) 87.00% compared to head (ec710b6) 87.07%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #435      +/-   ##
==========================================
+ Coverage   87.00%   87.07%   +0.06%     
==========================================
  Files         122      122              
  Lines       17016    17057      +41     
==========================================
+ Hits        14805    14852      +47     
+ Misses       2211     2205       -6     

Flag	Coverage Δ
unittests	87.07% <100.00%> (+0.06%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.