Fix regional cost bug #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppinchuk
added
bug
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #477 +/- ##
==========================================
+ Coverage 87.52% 87.59% +0.06%
==========================================
Files 122 122
Lines 18183 18228 +45
==========================================
+ Hits 15915 15967 +52
+ Misses 2268 2261 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
reVX test fails because of pandas 2.0. Moving forward with this for now |
github-actions bot
pushed a commit
that referenced
this pull request
Oct 23, 2024
Fix regional cost bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, regional multipliers would be applied twice - once during the generation run and once during the econ run. We need the econ data to be formalized at generation run time though, for output collection purposes. So, in this PR, I added a flag that let's reV know if econ values have already been adjusted. If so, no other adjustments are made.
A test for regional multipliers did exist, but it was only on the econ module. This bug happens when generation and econ are both run so this bug slipped through the cracks. I added a new test that checks the multipliers for a combined generation + econ run